search

egeland / nagios-rbl-check

Icinga/Nagios spam blacklist check, written in python
GNU General Public License v3.0
34 stars 18 forks source link

Better algorithm to display output, and PEP8 #6

Closed maethor closed 9 years ago

maethor commented 9 years ago

Hi,

Thanks a lot for this plugin which save me a lot of time. I have cleaned a little the last algorithm that computes the state and returns the ouput. And I have make all the script PEP8 compatible.

I thought you could be interrested in merging these modifications. Do whatever you want with this PR :)

Thanks again.

egeland commented 9 years ago

Thanks for taking the time to improve this! :+1:

Looks good - I'm not actively using this plugin at the moment, so I'll trust that you or others have tested/will test it.

:shipit:

maethor commented 9 years ago

In fact, I end up rewriting it more to manage multiple addresses and IPv6:

https://github.com/Sysnove/shinken-plugins/blob/master/check_rbl.py

With this version, when I check a domain name, the script checks both it's IPv4 and it's IPv6. But this version depends on dnspython, so I will not make a pull request for it.

egeland commented 9 years ago

That version looks good, too - if you could make the IPv6 optional, I'd be happy to merge it in. We (IT people) need to support IPv6 more.. :smile:

egeland commented 8 years ago

In case you have further updates, I've added you as a collaborator on this repo, so you can push any changes you feel are suitable. :)

maethor commented 8 years ago

Thank you :)