search

egeldenhuys / black-fitch

[DEPRECATED] Black-box Unit Tests for Fitchfork practicals and assignments
GNU General Public License v3.0
8 stars 4 forks source link

Assignment 2: Unnecessary testing. #30

Closed Quantum-Sicarius closed 8 years ago

Quantum-Sicarius commented 8 years ago

Fitch fork does not expect us to throw from our code, but rather to catch it and print out the error. (I know it seems silly.) I am getting full marks on Fitchfork but blackfitch is complaining about thrown != true. Not a problem but may be misleading to some users.

egeldenhuys commented 8 years ago

It seems I misinterpreted the specifications then. I will review the tests and the requirements. Thank you for testing

egeldenhuys commented 8 years ago

It appears fitchfork is not testing for exceptions at all. I have tagged the tests to allow them to fail as expected.

CGVanWyk commented 8 years ago

hey I think your inheritance at zigzag.h should be class ZigZag: public virtual TranspositionCipher

egeldenhuys commented 8 years ago

@BestStriker, I understand that using virtual base classes are most useful when working with multiple inheritance. Virtual inheritance in this case does not seem to make a difference.

See Virtual Base Classes Tutorial