search

egeldenhuys / black-fitch

[DEPRECATED] Black-box Unit Tests for Fitchfork practicals and assignments
GNU General Public License v3.0
8 stars 4 forks source link

Practical 8 Tests #38

Closed devosray closed 7 years ago

devosray commented 7 years ago

Made a few basic tests for Task 1 & 2 of Practical 8. Mostly pushing to get a working structure for adding tests for Task1 and Task2.

Sidenote: How can I create a pull request to a new branch? Seems like I can only push to your master?

devosray commented 7 years ago

I'm done with Prac 8. I think the questions are very simple to do and that the tests are sufficient and ready to merge.

egeldenhuys commented 7 years ago

Sidenote: How can I create a pull request to a new branch? Seems like I can only push to your master?

The repo owner has to create and change the base branch for the pull request.

In the future we might implement a review process where at least two people get full marks using the tests before merging into master.

Thank you for the tests @devosray, will be merging into master.

Quantum-Sicarius commented 7 years ago

Excellent work @devosray! @egeldenhuys I think that is a good idea :+1: