search

egeldenhuys / ghost-cloudflare-r2

Cloudflare R2 storage adapter for Ghost
MIT License
29 stars 4 forks source link

fix: upload video erros #5

Closed bikekoala closed 3 months ago

egeldenhuys commented 4 months ago

Hi @bikekoala , thank you for the pull request! I have not tried uploading videos yet so I did not know about the error.

I will test it in the next week and merge if everything works fine.

fritz-fritz commented 3 months ago

Hmm, I can verify that this does indeed allow the upload to complete and be served... but it seems we might be missing something in the storage api as it leads to a thumbnail being generated and stored at /undefined/<media name>_thumb.jpg

This might be a temporarily okay bit to merge. But I think more work is needed.

egeldenhuys commented 3 months ago

Thank you for the feedback @fritz-fritz !

I created an issue for the thumbnail storage bug.

fritz-fritz commented 3 months ago

Hmm, when I tested. I manually applied the change in the src/index.ts but didn't switch to the branch so didn't have the changes in the package-lock.json. They seem to be breaking my uploads somehow. You might need to rollback if you haven't tested?