egelmex / TinkerWeb

2 stars 3 forks source link

BarCamp Logo can't display SVG #58

Closed IceQubed closed 9 years ago

IceQubed commented 9 years ago

Hi, in the blog post from the 14th June, the BarCamp logo linked is not displaying in Chrome (38.0.2125.44 beta-m).

If I right click and select "Open image in new tab", it saves the SVG file to my computer. When I open the downloaded image, it loads perfectly in Chrome, suggesting that Chrome may only have the ability to correctly display SVGs on their own.

Perhaps either look into SVG compatibility options or convert it to a PNG.

egelmex commented 9 years ago

Of this is on the live site this has already been fixed on the test site. On 7 Sep 2014 13:10, "IceQubed" notifications@github.com wrote:

Hi, in the blog post from the 14th June, the BarCamp logo linked is not displaying in Chrome (38.0.2125.44 beta-m).

If I right click and select "Open image in new tab", it saves the SVG file to my computer. When I open the downloaded image, it loads perfectly in Chrome, suggesting that Chrome may only have the ability to correctly display SVGs on their own.

Perhaps either look into SVG compatibility options or convert it to a PNG.

— Reply to this email directly or view it on GitHub https://github.com/egelmex/TinkerWeb/issues/58.

graymalkin commented 9 years ago

It's a problem with the serving on the image, it's not being sent with correct MIME type from the Amazon server.

http://stackoverflow.com/questions/18009493/content-type-to-be-used-for-uploading-svg-images-to-aws-s3

graymalkin commented 9 years ago

Incorrect server response from Amazon:

simon@vps58459:~$ curl -I http://www.tinkersoc.org/assets/images/2014-06-14-BarC                                                                                        amp-Canterbury/barcamp.svg
HTTP/1.1 200 OK
x-amz-id-2: HBcEXR4mVjq8pN6yKPOTxWAheojniNW1hsocbzLIhik7QdvbN3yXytT+uTWleWf0
x-amz-request-id: F1AD4A309ABD5F79
Date: Sun, 07 Sep 2014 22:07:16 GMT
x-amz-meta-s3cmd-attrs: uid:1001/gname:users/uname:tinker/gid:100/mode:33188/mti                                                                                        me:1403601379/atime:1402826589/md5:6038422f9814b6a11696c3700c4cd444/ctime:140360                                                                                        1379
Last-Modified: Tue, 24 Jun 2014 09:46:46 GMT
ETag: "6038422f9814b6a11696c3700c4cd444"
Content-Type: binary/octet-stream
Content-Length: 10799
Server: AmazonS3

Of course, just using a PNG is easier, and more compatible.

egelmex commented 9 years ago

Closing as "fixed" on live site