Is upcoming broken?

[graymalkin]

It would appear there's been some sort of API change.

      if (this.opts.feed_url) {
        return this.opts.feed_url;
      } else if (this.opts.mode === 'updates') {
        return "https://www.google.com/calendar/feeds/" + this.opts.calid + "/public/full?alt=json-in-script&max-results=" + this.opts.maxitem + "&orderby=lastmodified&sortorder=descending";
      } else {
        return "https://www.google.com/calendar/feeds/" + this.opts.calid + "/public/full?alt=json-in-script&max-results=" + this.opts.maxitem + "&orderby=starttime&futureevents=true&sortorder=ascending&singleevents=true";
      }

See jquery.gcal_flow.js:125

Investigating, it looks like, the URL has changed slightly.

This does work (in the potential patch): https://www.google.com/calendar/feeds/tinkersoc.org_jgvajjns79sp34mvqntl81rub0%40group.calendar.google.com/public/basic?alt=json-in-script

This does not work (in the current implementation): https://www.google.com/calendar/feeds/tinkersoc.org_jgvajjns79sp34mvqntl81rub0%40group.calendar.google.com/public/full?alt=json-in-script

The change is from basic to full at the end of the URL.

[graymalkin]

Potentially it's sane to have a submodule to the module's source, rather than a copy? https://github.com/sugi/jquery-gcal-flow/

[egelmex]

Last time I looked submodules in git didn't act like you would expect, but I hear there has been some work done on them.

If you want to experiment and bring up a pull req I will happily merge. = On Thu Jan 15 2015 at 10:05:52 AM Simon Cooksey notifications@github.com wrote:

Potentially it's sane to have a submodule to the module's source, rather than a copy? https://github.com/sugi/jquery-gcal-flow/

— Reply to this email directly or view it on GitHub https://github.com/egelmex/TinkerWeb/issues/88#issuecomment-70063941.

[graymalkin]

Submodules are essentially "I want this git repo here, at this commit pointer" -- you can do a reccursive git pull, to update all submodules.

I'll have a play when I'm not at work, and have an internet connection at home that allows me to ssh >.<

[egelmex]

Any change you will have time to make a pull req to get this fixed (if if hacky and raise a new ticket to improve it?)

[graymalkin]

Should be easy enough, the only difficulty will be forcing jekyll to compile the coffee script without adding front matter to the file (as that would defy the point of having a git submodule)

It may be that I add a Makefile which does some legwork first. That could be very nice for doing things like

make serve
make local
make deply

Etc. Thoughts?

[egelmex]

There is already a make script on my dev server (you should have access) that I use to push to S3. Might be worth looking at/extending that.

On Tue Jan 27 2015 at 12:05:45 PM Simon Cooksey notifications@github.com wrote:

Should be easy enough, the only difficulty will be forcing jekyll to compile the coffee script without adding front matter to the file (as that would defy the point of having a git submodule)

It may be that I add a Makefile which does some legwork first. That could be very nice for doing things like

make serve make local make deply

Etc. Thoughts?

— Reply to this email directly or view it on GitHub https://github.com/egelmex/TinkerWeb/issues/88#issuecomment-71637367.