search

egeloen / IvoryCKEditorBundle

Provides a CKEditor integration for your Symfony project.
MIT License
336 stars 114 forks source link

Fixes Deprecated method usage #229

Closed artoroz closed 8 years ago

artoroz commented 8 years ago

In Symfony 2.8.4 i get the following deprecation error message on the 4.0.1 tag in dev-master it has changed a bit but the error still occurs

The hardcoded value you are using for the $referenceType argument of the Symfony\Component\Routing\Generator\UrlGenerator::generate method is deprecated since version 2.8 and will not be supported anymore in 3.0. Use the constants defined in the UrlGeneratorInterface instead.

egeloen commented 8 years ago

This is weird it has not been detected by the Symfony PHPUnit bridge... Can you add a test which spot this deprecation? If you can't, I will do it but not now :) I ask for a test because I don't think your code works with all Symfony versions (this bundle supports Symfony 2.2+ right now and the constant is only available since Symfony 2.8).

Anyway, thanks a lot for reporting and also try to fix it :)

egeloen commented 8 years ago

Nevermind about the test... We can't add it because the router is mocked...

egeloen commented 8 years ago

@artorozenga I have fixed it in the referenced PR. Thanks you!