search

egeloen / IvoryCKEditorBundle

Provides a CKEditor integration for your Symfony project.
MIT License
336 stars 114 forks source link

Use curl or symfony internal instead file_get_contents #312

Closed jkroepke closed 6 years ago

jkroepke commented 7 years ago

Hi,

/cc @f1terit

our server is secured by a firewall. We have to go via proxy to access the internet.

By default, file_get_contents can not go over a proxy. I have to configure the stream context which is not possible for me at composer time.

https://github.com/egeloen/IvoryCKEditorBundle/blob/4d59b5467a9d1aefa2cd7d0fc239a46c17ccb0ce/Installer/CKEditorInstaller.php#L188

It's possible to use curl instead file_get_contents?

egeloen commented 7 years ago

Does an entry in the composer extra allowing you to configure your proxy would be enough to you?

jkroepke commented 7 years ago

Yeah.

Otherwise auto detect a proxy, if the environment variable http_proxy or https_proxy is defined.

egeloen commented 7 years ago

Btw, what do you refer to when you say "Symfony internal"?

jkroepke commented 7 years ago

Symfony http client libraries.

http://symfony.com/doc/current/components/browser_kit.html

or external bundles like

https://github.com/8p/GuzzleBundle