search

egeloen / IvoryCKEditorBundle

Provides a CKEditor integration for your Symfony project.
MIT License
336 stars 114 forks source link

Allow symfony 4 #340

Closed ElectricMaxxx closed 6 years ago

ElectricMaxxx commented 6 years ago

A next try to get it on SF4.

fbourigault commented 6 years ago

@ElectricMaxxx could you run vendor/bin/php-cs-fixer to get a better diff?

szymach commented 6 years ago

Take a look at #342, I have managed to get it working and running tests for all components in 4.x

ElectricMaxxx commented 6 years ago

That looks green now :-)

ElectricMaxxx commented 6 years ago

@fbourigault i have no cs-fixer in my vendor.

ElectricMaxxx commented 6 years ago

@fbourigault @szymach shall i move SF 3.4 and SF4 out of the allowed failures now?

fbourigault commented 6 years ago

i have no cs-fixer in my vendor.

It's a dev requirement, so you should have it!

ElectricMaxxx commented 6 years ago

oh, you are right :-)

ElectricMaxxx commented 6 years ago

Fixed and ready.

ElectricMaxxx commented 6 years ago

@szymach i fixed your stuff, i think, hopefully the tests are going green.

szymach commented 6 years ago

Well until a new maintainer comes up, there is not much left to do here, unfortunately. I myself have switched to a fork my company have made for this repo and am investigating how hard would it be to use CKEditor 5 with just plain javascript, without Symfony integration.

ElectricMaxxx commented 6 years ago

@szymach any chance to merge & release befor the new container man comes? @szymach what about you?

szymach commented 6 years ago

I am not a maintainer, I cannot do anything with this repo, sorry.

ElectricMaxxx commented 6 years ago

@fbourigault what about you?

fbourigault commented 6 years ago

I asked @egeloen to become maintainer, but he seems busy.