search

egeloen / IvoryGoogleMapBundle

Google Map API v3 integration for your Symfony2 project.
https://github.com/egeloen/ivory-google-map
MIT License
217 stars 152 forks source link

ContextErrorException when not connected to internet #107

Closed soerenmartius closed 10 years ago

soerenmartius commented 10 years ago

Hey, if i am not connected to the internet the GeocoderProvider throws an exception. Shouldnt this be checked before and easily show a warning or log something instead of breaking the whole process?

ContextErrorException: Catchable Fatal Error: Argument 1 passed to Ivory\GoogleMap\Services\Geocoding\GeocoderProvider::buildGeocoderResponse() must be an instance of stdClass, null given, called in /vagrant/www/vendor/egeloen/google-map/src/Ivory/GoogleMap/Services/Geocoding/GeocoderProvider.php on line 218 and defined in /vagrant/www/vendor/egeloen/google-map/src/Ivory/GoogleMap/Services/Geocoding/GeocoderProvider.php line 355

egeloen commented 10 years ago

Thx for reporting it! The issue has been fixed in https://github.com/egeloen/ivory-google-map/commit/a1608aed2646aeade0908e3be7f53ec425ca05d8