search

egeloen / IvoryGoogleMapBundle

Google Map API v3 integration for your Symfony2 project.
https://github.com/egeloen/ivory-google-map
MIT License
217 stars 152 forks source link

Added Version fix which allows any symfony version gte 3 #190

Closed Obermeijer closed 7 years ago

Obermeijer commented 7 years ago

Removes version lock and allows Symfony >= 3

egeloen commented 7 years ago

I'm a little bit confused with your PR. AFAIK, ^3.0 already allows any symfony 3.x versions while keeping BC whereas your constraint would allow any 3.x versions as well as 4.x, 5.x, ... (something we don't want at all for now as we don't know what Symfony will break in further major versions).

Can you clarify which bug do you encounter while submitting this PR?

lastdreamer7591 commented 7 years ago

I can not install the bundle with composer with Symfony 3.2.1. Maybe this pull-request solves the problem?

JoydS commented 7 years ago

Please, you need to make a new tag version. 2.2.1 is "symfony/framework-bundle": "~2.1"

Obermeijer commented 7 years ago

Sorry for the late response due to the holidays. Happy new year btw :-)

I had this issue wrong, apparently when using composer require egeloen/google-map-bundle it defers to version 2.2.1 which is indeed Symfony2 like JoydS said.

For Symfony3.x you'll have to specify the version when using composer require (composer require egeloen/google-map-bundle master) so this is indeed a matter of adding a new tag version.

egeloen commented 7 years ago

Ok, I see the issue now but unfortunatelly I'm not ready for the next major release... The master branch has major BC breaks and the next tag will not be a patch one but a major one (the 3.x one).

Obermeijer commented 7 years ago

Well I'm fine with the workaround for the moment. I'm using it with Symfony3.2 and it works fine.

For anyone else who has this issue, install the bundle using: composer require egeloen/google-map-bundle master.

Closing this pull, thanks for your time though!