search

egeloen / IvoryGoogleMapBundle

Google Map API v3 integration for your Symfony2 project.
https://github.com/egeloen/ivory-google-map
MIT License
217 stars 152 forks source link

Incorrect description for autocomplete for restriction by country #207

Closed AlexBykovski closed 7 years ago

AlexBykovski commented 7 years ago

I tried to use like described here https://github.com/egeloen/IvoryGoogleMapBundle/blob/master/Resources/doc/place_autocomplete.md#configure-components, but I got an error The option "country" does not exist.

Then I checked code and found out that it should be in documentation: $builder->add('field', PlaceAutocompleteType::class, [ 'components' => [AutocompleteComponentType::COUNTRY => 'fr'] ]);

Please, add it.

egeloen commented 7 years ago

@AlexBykovski Thanks for your feedbacks. Writing good code is hard but writing good docs (without typos) is even harder... :) Can you make a PR to fix it?

AlexBykovski commented 7 years ago

@egeloen I tried, but seems that I haven't access image

AlexBykovski commented 7 years ago

@egeloen BTW, thank you for this bundle, I used it and very satisfied. Good work! 👍

egeloen commented 7 years ago

@AlexBykovski You can't push directly to this repository. Instead you need first to fork it (https://help.github.com/articles/fork-a-repo/) and then create a PR from your fork (https://help.github.com/articles/creating-a-pull-request/) that I will review and merge into the master branch of this repository :)

egeloen commented 7 years ago

Your issue has been fixed by 341047680ee643407d274214288283efe3014661