search

egeloen / IvoryGoogleMapBundle

Google Map API v3 integration for your Symfony2 project.
https://github.com/egeloen/ivory-google-map
MIT License
217 stars 152 forks source link

Load the google map api only once #30

Closed egeloen closed 12 years ago

egeloen commented 12 years ago

I have started to fix #28. The main problem is to be able to keep the dynamic library loading & the async behavior.

Venzon commented 12 years ago

I think it is good approach, it will fix basic problem with renderJavascripts method and will not break any BC. For example loading google map api js more then once make map markers broken.

I think it would be usefull to add attribute/option to map object which force helper not to render google maps api javascript... maybe some people would like to load it in head section of page or even in different way.

Venzon commented 12 years ago

Hi Can you merge changes into master branch?

egeloen commented 12 years ago

I will merge it into master because without it, the bundle doesn't work if you try to use many maps on the same page. Btw, it is absolutely not the good fix IMO. Please don't close the linked issue.