egeloen / IvoryGoogleMapBundle

Google Map API v3 integration for your Symfony2 project.
https://github.com/egeloen/ivory-google-map
MIT License
217 stars 152 forks source link

google maps validation #36

Closed webspin closed 11 years ago

webspin commented 12 years ago

The current implementation doesn't validate html5:

solution:

Templating/Helper/Maphelper.php line 285-300

replace the '&' (ampersand) in the url with '&'

Ok?

egeloen commented 12 years ago

Can you elaborate a bit more?

webspin commented 12 years ago

Sure.

We use your bundle in our sites, and where we put {{ google_map_container(map) }}

you include the js to render the map.

but

The js is of the kind <script src="{some-url}"></script> but in {some-url} the parameters are set with '&param=value' which is not valid html5, it should be '&amp;param=value'

More info on this ampersand issue: http://stackoverflow.com/questions/3493405/do-i-really-need-to-encode-as-amp

egeloen commented 11 years ago

This is now fixed by egeloen/ivory-google-map@f32f67f