search

egeloen / IvoryGoogleMapBundle

Google Map API v3 integration for your Symfony2 project.
https://github.com/egeloen/ivory-google-map
MIT License
217 stars 152 forks source link

adding markers clustering option #48

Closed ivannis closed 11 years ago

ivannis commented 11 years ago

Adding clustering using the MarkerClusterer library for Google Maps v3

egeloen commented 11 years ago

Thanks! Fix my comment & then, I will merge it :+1:

egeloen commented 11 years ago

@ivannis I'm sorry but I have recently updated the source to extract the business code in a deciated lib for reusability. I have totally forgotten your PR & these changes makes it unmergeable & invalid :s

If you can make a PR against the egeloen/ivory-google-map repo to add the headmap layer & update this PR to impact the bundle, you're awesome! :)

Anyway, if you can't, I will reuse your code to implement it but currently, I'm fixing issues.

theZizoo commented 11 years ago

@ivannis and @egeloen

Is there an ETA on this feature?

Would be greatly appreciated.

egeloen commented 11 years ago

@theZizoo Moving this feature to the egeloen/ivory-google-map repo is currently at the end of my TODO list. Anyway, if you have some time, you can do it. It will be very appreciated too :)

ivannis commented 11 years ago

@egeloen I'm back, I will make soon a PR to integrate this functionality :)

egeloen commented 11 years ago

@ivannis Thx

smoya commented 11 years ago

+1 to the PR!

egeloen commented 11 years ago

@ivannis Any news?

egeloen commented 11 years ago

After looking a little bit more of what Google Map API provides for optimize a large number of markers, it seems that many techniques are available (see here).

The implementation of this PR only uses the Marker Cluster approach. It would be great if we can provide different "strategies" (Marker Cluster, Grid-based, ...) & switch easily between these different strategies.

What's your opinion?

egeloen commented 11 years ago

For the record, I will work on this feature as It seems the most asked by the community & @ivannis seems busy right now. I come back ASAP with something working :)

eperinan commented 11 years ago

Hi Egeloen !!

Any news about this feature?

egeloen commented 11 years ago

I know it is a very important feature for you but I prefer take my time & come with the right implementation instead of making something not perfect which will cause further BC breaks. I have merged all mergeable contributions :) Now this one is my next priority.

The main issue with this feature is I would like to allow people to use different cluster strategies instead of a single one...

egeloen commented 11 years ago

Before continue my work on this feature, I would like to get feedback on how would you like it? First of all, are we talking about client or server marker clustering?

theZizoo commented 11 years ago

@egeloen thanks for picking this up again, and all your effort on this great bundle.

Personally, I would prefer server side clustering.

Cheers

egeloen commented 11 years ago

For the record, I have pushed my proposal for marker clustering. The bundle needs some love for integrating these changes which breaks BC for map helper.