egeloen / IvoryGoogleMapBundle

Google Map API v3 integration for your Symfony2 project.
https://github.com/egeloen/ivory-google-map
MIT License
217 stars 152 forks source link

Initial implementation of heatmap layers #50

Closed umpirsky closed 8 years ago

blazarecki commented 11 years ago

Thanks for contribution.

Can you please add in the .travis.yml php 5.3.3 and 5.5.

You can also add the symfony in travis.yml.

See https://github.com/egeloen/IvoryCKEditorBundle/blob/master/.travis.yml for example.

umpirsky commented 11 years ago

@benjaminlazarecki Done.

blazarecki commented 11 years ago

Nice but can you also add symfony 2.0.* ?

This bundle should work with all symfony versions.

Best regards

umpirsky commented 11 years ago

@benjaminlazarecki Done.

blazarecki commented 11 years ago

Sorry guy but Symfony just add the 2.2 tag, can you add this in the .travis.yml

Thanks

egeloen commented 11 years ago

@benjaminlazarecki Thanks dude for helping on this PR :)

@umpirsky Thanks for your contribution! Unfortunately, I have updated the code recently in order to extract the business code in a dedicated lib for reusability. Theses changes make your PR unmergeable & invalid. Sorry for that :s If you can make a PR against the egeloen/ivory-google-map repo to add the headmap layer & update this PR to impact the bundle, you're awesome! :)

Anyway, if you can't, I will reuse your code to implement it but currently, I'm fixing issues.

emmanuel-tesson commented 10 years ago

@egeloen Did you implement heatmap finally in your bundle ?

egeloen commented 10 years ago

Currently, this feature is not implemented.

emmanuel-tesson commented 10 years ago

Please, could you give me some help to implement heat map ? i just want some explanation on the files structures to add this new feature. Does it exist some docs or pdf ?

egeloen commented 10 years ago

I need to re-read the doc first and then I will come back with my vision of how the feature should be implemented.

egeloen commented 8 years ago

The feature has been added to the library via egeloen/ivory-google-map#158 but will only be part of the 2.x version of the library and the 3.x version of the bundle.