Closed egeloen closed 11 years ago
Seems good to me, aside of the my little comments. This PR will add a lot of flexibility to the bundle. Also, do you have an idea about the bug in Travis ? Seems that it fails at loading dependencies.
@mattsnowboard This PR should allow you to inject any services in your controller :)
@tmartin Can you give me your opinion?
This PR removes all prototyped services & use builders to create new objects instead (It fixes #45).
Additionally:
addMethodCall
conditionally instead (This help to fix issues with the removal of all default values).For the Travis part, I have decided to remove the Symfony
dev-master
version as I can't install it (either withdev-master
,2.2.*@dev
or anything else). Additionally, I have added a--no-update
flag in order to not update the vendor when we require a package.