egeloen / IvoryGoogleMapBundle

Google Map API v3 integration for your Symfony2 project.
https://github.com/egeloen/ivory-google-map
MIT License
217 stars 152 forks source link

Remove prototyped services #56

Closed egeloen closed 11 years ago

egeloen commented 11 years ago

This PR removes all prototyped services & use builders to create new objects instead (It fixes #45).

Additionally:

For the Travis part, I have decided to remove the Symfony dev-master version as I can't install it (either with dev-master, 2.2.*@dev or anything else). Additionally, I have added a --no-update flag in order to not update the vendor when we require a package.

tmartin commented 11 years ago

Seems good to me, aside of the my little comments. This PR will add a lot of flexibility to the bundle. Also, do you have an idea about the bug in Travis ? Seems that it fails at loading dependencies.

egeloen commented 11 years ago

@mattsnowboard This PR should allow you to inject any services in your controller :)

@tmartin Can you give me your opinion?