search

egeloen / IvoryGoogleMapBundle

Google Map API v3 integration for your Symfony2 project.
https://github.com/egeloen/ivory-google-map
MIT License
217 stars 152 forks source link

Directions $copyrights issue #72

Closed dupuchba closed 11 years ago

dupuchba commented 11 years ago

Hi all,

My prod. website is offline because of this error (no push to prod today) and it was working well before.

capture decran 2013-06-04 a 16 50 53

it seems that the undefined property of $copyrights fucked up everything...

egeloen commented 11 years ago

@dupuchba Google has removed the property?

dupuchba commented 11 years ago

No it doesn't look like there change anything but when I var_dump my directionRoute object, there is no $copyright prop...

capture decran 2013-06-04 a 18 08 50 capture decran 2013-06-04 a 18 08 27

egeloen commented 11 years ago

Strange... According to https://developers.google.com/maps/documentation/directions/#Routes the route should contain a copyrights. As the behavior seems not always same, IMO, we should make a check when the route is rebuild. If there is no copyrights, fallback on null. What's your opinion?

dupuchba commented 11 years ago

That's what seems to happen with us (websites work well but sometimes no copyrights... which crash the page...) In my opinon if there is no copyrights, then set it to '' or null. You do it? or i do it?

egeloen commented 11 years ago

I'm currently fixing it :)

dupuchba commented 11 years ago

ok cool :) :8ball:

egeloen commented 11 years ago

The issue should be fixed by egeloen/ivory-google-map@b5bcd661bf

Can you confirm? :)

dupuchba commented 11 years ago

Yep, good! I hope you this won't happen again for other properties :)... Thx for your reactivity!

By the way if you have 2min, I also raised an issue in egeloen/ivory-google-map#23 . I already saw your work un-merged in google-places for your pull-request egeloen/ivory-google-map#18 .

Good work, are you going to merge it? Anyway I think it should be possible to add services without any php implementations in the few cases (but real :) ) where you have to use the map with other services and where you can't load twice the google map api!