search

egeloen / IvoryGoogleMapBundle

Google Map API v3 integration for your Symfony2 project.
https://github.com/egeloen/ivory-google-map
MIT License
217 stars 152 forks source link

widop_http_adapter.curl not optional #91

Closed Richtermeister closed 10 years ago

Richtermeister commented 10 years ago

Hi all, this is a great bundle! Maybe I missed something in the documentation, but the readme left me with the impression that the widop http adapter is only needed if I want to use distance or direction services.

However, it seems by default the bundle depends on this service to be present and does not seem to allow disabling these sections via config.

egeloen commented 10 years ago

@Richtermeister There is already lot of tickets about this, so, maybe it is me who misses something. Why is it mandatory?

Richtermeister commented 10 years ago

@egeloen The DI configuration sets widop_http_adapter.curl as default value for the adapters for the two sections distance_matrix and directions and uses addDefaultsIfNotSet(), which results in these services being defined with this dependency.

I just proposed a solution here: https://github.com/egeloen/IvoryGoogleMapBundle/pull/92 Let me know if you'd rather have the other solution to stay Symfony 2.1 compatible.

egeloen commented 10 years ago

Close by #95