Make http adapter optional

egeloen / IvoryGoogleMapBundle

Google Map API v3 integration for your Symfony2 project.

https://github.com/egeloen/ivory-google-map

MIT License

217 stars 152 forks source link

Make http adapter optional #92

Closed Richtermeister closed 10 years ago

Richtermeister commented 10 years ago

This PR disables the distance_matrix and direction sections by default, so there is no default dependency on http adapter. Default section settings can be enabled via directions: true.

Note that this makes use of a Symfony 2.2 feature. If this is a no-go, we can also not set sections defaults and watch for the presence of sections in extension via isset().

egeloen commented 10 years ago

Ok, I got it this time. For the dependencies, I would prefer to maintain a compatibility with Symfony 2.*, so your second proposal seems the good solution. Btw, can you make your PR against the 2.0 branch? Thx

Richtermeister commented 10 years ago

Backwards Compatible version here: https://github.com/egeloen/IvoryGoogleMapBundle/pull/93

Thanks.

egeloen commented 10 years ago

Closing for #95