search

egeloen / IvoryLuceneSearchBundle

Provides a Zend Lucene Search integration for your Symfony2 project.
MIT License
29 stars 11 forks source link

Add query parser encoding option #9

Closed fmarinheiro closed 10 years ago

fmarinheiro commented 10 years ago

Hi, needed UTF-8 support and noticed that the bundle doesn't have an option to set ZendSearch QueryParser encoding, which was the only way i could get it to work properly. Tried a different analyzer but it didn't work, i had problems related to iconv. I've made some changes to your bundle to accept a new configuration parameter called query_parser_encoding to set the query parser encoding.

Great tool for those who need to use lucene by the way!!!

egeloen commented 10 years ago

Thanks for your contribution! Btw, can you take a look to the tests which seems broken (mainly due to the BC break introduced by your change)?

fmarinheiro commented 10 years ago

I've fixed the issues you pointed out and the tests are passing know. I did not touched the bundles test suite but i can make the changes the test cases to cover this new configuration parameter if you prefer. Just let me know and i'll do it. Good work.

egeloen commented 10 years ago

If you can add some tests, it would be great :)

fmarinheiro commented 10 years ago

I've removed the extra spaces in the setIndex function comment block and the test are know covering the new option.

egeloen commented 10 years ago

I just squashed and cherry-pick your commits into master. Thanks for your contribution! Well done!