search

egenn / rtemis

Advanced Machine Learning and Visualization
https://rtemis.org
GNU General Public License v3.0
140 stars 19 forks source link

`mplot3.xy` does not respect `ylim` when adding `fit` #30

Closed stnava closed 3 years ago

stnava commented 3 years ago

example below builds on the documentation code.

this:

  mplot3.xy(x, list(squared = ysq, cubed = ycu), fit = "gam",ylim=c(-20,20))

versus

  mplot3.xy(x, list(squared = ysq, cubed = ycu), ylim=c(-20,20))

would expect limits to be -20, 20 in both cases. not sure if this is intended behavior.

based on remotes install this AM.

egenn commented 3 years ago

Thank you, Brian! ee58a70f3abfbd42b5bc590f6b1a33e73ddb0cf8 should fix this.

Stathis

stnava commented 3 years ago

perfect thanks!