search

egeriis / laravel-jsonapi

Make it a breeze to create a jsonapi.org compliant APIs with Laravel 5.
MIT License
146 stars 27 forks source link

updates resource output to correctly nest attributes #14

Closed ninjapenguin closed 9 years ago

ninjapenguin commented 9 years ago

Spec:

"attributes": an "attributes object", providing information about a resource.

See: http://jsonapi.org/format/#document-structure-resource-objects

pmccarren commented 9 years ago

@ninjapenguin Has json-api/json-api#588 been released yet? My understanding is that master is headed towards rc4, however it's not quite there yet (I could for sure be wrong though :) ) ref: manyminds/api2go#118

mjanda commented 9 years ago

Current ember-data (1.13.4) expects this format, so it should be at least optional and mentioned in readme?

egeriis commented 9 years ago

@ninjapenguin Can you create a new pull request which doesn't conflict with master? :) Thanks.

egeriis commented 9 years ago

Now that JSON API v1 has officially been released, it would be great to have this PR merged. @ninjapenguin do you have the time to fix the merge conflict, please?

egeriis commented 9 years ago

@ninjapenguin Desperately pinging you again :)

ninjapenguin commented 9 years ago

@egeriis I'll take a look at this and update the PR this weekend!

egeriis commented 9 years ago

That's just awesome @ninjapenguin :+1:

ninjapenguin commented 9 years ago

@egeriis This now looks fine to me!

egeriis commented 9 years ago

Thank you so much @ninjapenguin