egeriis / laravel-jsonapi

Make it a breeze to create a jsonapi.org compliant APIs with Laravel 5.

MIT License

146 stars 27 forks source link

JSONAPI.org compliance #21

Closed manuelfink closed 9 years ago

manuelfink commented 9 years ago

Just being serious, is this lib compliant to jsonapi.org? E.g I'm just wondering aren't attributes not supposed to be in an attributes child? http://jsonapi.org/format/#document-resource-object-attributes. For me the lib is returning attributes as a direkt child of each object and not underneath object.attributes.

egeriis commented 9 years ago

I believe we had a pull request not far ago, which updated this when the specification had been changed.

If it's not working as specified, you are very welcome to do a pull request.

egeriis commented 9 years ago

I just checked up and see that the PR wasn't merged due to conflicts. https://github.com/echo-it/laravel-jsonapi/pull/14

egeriis commented 9 years ago

14 merged

manuelfink commented 9 years ago

Did you merge it?

2015-09-28 13:49 GMT+02:00 Ronni Egeriis Persson notifications@github.com:

14 https://github.com/echo-it/laravel-jsonapi/pull/14 merged

— Reply to this email directly or view it on GitHub https://github.com/echo-it/laravel-jsonapi/issues/21#issuecomment-143722038 .

egeriis commented 9 years ago

Yup, forgot to tag though. One minute.

egeriis commented 9 years ago

There we go. v2.4.