search

egg-mode-rs / egg-mode

a twitter api crate for rust
https://crates.io/crates/egg-mode
Mozilla Public License 2.0
371 stars 65 forks source link

Avoid `collect`ing `PercentEncode` into `String` #47

Closed tesaguri closed 6 years ago

tesaguri commented 6 years ago

PercentEncode (returned value of percent_encoding::utf8_percent_encode) implements Display trait, so allocating a String is unnecessary when format!ing it.

QuietMisdreavus commented 6 years ago

Oh, ouch, my 1.18.0 version testing is apparently so old, many of my dependencies have moved on. I'll go ahead and merge this, since stable seems to accept it. The CI configuration can be updated separately - whether with its own lockfile or to update our version guarantees.