eggheadio-github / stack-overflow-copy-paste

Utility functions copy/pasted (and modified slightly) from Stack Overflow

441 stars 606 forks source link

WIP: Cannot get coverage quite there #162

Closed dominictwlee closed 6 years ago

dominictwlee commented 6 years ago

Not quite sure how to get 100% coverage. I'd appreciate it if you could provide me with some feedback and point me in the right direction.

screenshot from 2018-04-26 00-00-24

Thanks for your help!

kentcdodds commented 6 years ago

Go ahead and open the coverage report that was generated in coverage/lcov-report/index.html. That should help you determine what lines of code are not being run so you know what tests need to be added :)

kentcdodds commented 6 years ago

Awesome! There are merge conflicts. GitHub has this cool feature where I can resolve those conflicts myself in the browser, but if you'd like practice at resolving them then I'll go ahead and let you do it. Let me know what you'd like me to do :)

codecov-io commented 6 years ago

Codecov Report

Merging #162 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #162   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          58     59    +1     
  Lines         193    201    +8     
=====================================
+ Hits          193    201    +8

Impacted Files	Coverage Δ
src/get-query-string-value.js	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 700a007...d239908. Read the comment docs.

dominictwlee commented 6 years ago

Oh odd, thought I already fixed the merge conflict. I wouldn't mind trying to resolve it myself, where should I look?