search

eggheadio-github / stack-overflow-copy-paste

Utility functions copy/pasted (and modified slightly) from Stack Overflow
441 stars 606 forks source link

WIP:Cannot get full coverage for getMiddle character function #189

Closed d-ivashchuk closed 6 years ago

d-ivashchuk commented 6 years ago

My first pull request! Had to use --no-verify because some error didn't let me commit the changes though. Thanks again for the opportunity!

d-ivashchuk commented 6 years ago

Great, will do that! Shall I again omit git hooks?

kentcdodds commented 6 years ago

You shouldn't have to omit git hooks if you have everything working :) But you can if you like.

codecov-io commented 6 years ago

Codecov Report

Merging #189 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #189   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          70     71    +1     
  Lines         277    278    +1     
=====================================
+ Hits          277    278    +1
Impacted Files Coverage Δ
src/getMiddle.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f58b735...244633e. Read the comment docs.