EstebanMarin commented 6 years ago

@kentcdodds The function and test were stright forward, however, I am gettting a strange error, confirmed by eslint: [eslint] dec2hex not found in '../src'

So when I run the test, it fails because it is not finding the module. I tried adding another .js module, and odd enough I was getting the same issue.

I also tried default import like import dec2hex from '../src' but then I get [eslint] No default export found in module. which makes sense if the module is not found

I ran npm run lint did not get any linting errors, and after ran a npm build too, but I was not able to solve it.

Can you please provide a guide so I can make the test run and be able to make the PR

Many thanks!!!!

codecov-io commented 5 years ago

Codecov Report

Merging #202 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #202   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          75     76    +1     
  Lines         327    329    +2     
=====================================
+ Hits          327    329    +2

Impacted Files	Coverage Δ
src/dec2hex.js	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d39b0aa...1a2b928. Read the comment docs.

EstebanMarin commented 5 years ago

@kentcdodds Thanks! after you said add it to src/index.js I slapped my self in the face 🤦🏻‍♂️

It is updated now. Many thanks!

eggheadio-github / stack-overflow-copy-paste

enhacement(dec2hex): js + test #202

Codecov Report