search

eggheadio-github / stack-overflow-copy-paste

Utility functions copy/pasted (and modified slightly) from Stack Overflow
441 stars 606 forks source link

feat(largest): finds largest number in an array #229

Closed AkashRajpurohit closed 5 years ago

AkashRajpurohit commented 5 years ago

Most of the changes in src/index.js is due to prettier configuration of my vscode. everything else is cool!

codecov-io commented 5 years ago

Codecov Report

Merging #229 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #229   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          88     89    +1     
  Lines         394    397    +3     
=====================================
+ Hits          394    397    +3
Impacted Files Coverage Δ
src/largest.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e5d379...c489ff9. Read the comment docs.

AkashRajpurohit commented 5 years ago

Cool it passed. Thanks for the suggestion about running the travis-ci script npm run validate locally to test before commiting. Will keep a habit for doing that in upcoming open source contributions as well. Cheers