search

eggheadio-github / stack-overflow-copy-paste

Utility functions copy/pasted (and modified slightly) from Stack Overflow
441 stars 606 forks source link

feat(second): add second function #242

Closed yeashinr closed 5 years ago

yeashinr commented 5 years ago

Please let me merge.

yeashinr commented 5 years ago

I have resolved the issues that you mentioned. But, not sure about the conflicting one. I rebase onto master. Not sure whether it solves the issue or not.

kentcdodds commented 5 years ago

There are still conflicts, but I can fix those for you no problem :) I'm not sure what happened.

codecov-io commented 5 years ago

Codecov Report

Merging #242 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #242   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          93     94    +1     
  Lines         453    454    +1     
=====================================
+ Hits          453    454    +1
Impacted Files Coverage Δ
src/second.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 38b6e73...8f2913f. Read the comment docs.