search

eggheadio-github / stack-overflow-copy-paste

Utility functions copy/pasted (and modified slightly) from Stack Overflow
441 stars 606 forks source link

sa #247

Open sreysa opened 5 years ago

sreysa commented 5 years ago

i dun want to say anything about it , it is so hard.

codecov-io commented 5 years ago

Codecov Report

Merging #247 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #247   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          94     94           
  Lines         454    454           
=====================================
  Hits          454    454

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d00b122...4a263a7. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #247 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #247   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          94     95    +1     
  Lines         454    465   +11     
=====================================
+ Hits          454    465   +11
Impacted Files Coverage Δ
src/armstrong.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d00b122...0a5994b. Read the comment docs.

sidag95 commented 5 years ago

@sreysa Seems like you have added a bunch of c files. I am afraid this particular repo is only for javascript functions and thus this PR might not be acceptable (right @kentcdodds ?) Side Note: Before raising a PR, try and remove all the redundant code that you have commented out just so that the code base is clean