eggheadio-projects / progressive-web-apps-in-react-with-create-react-app

19 stars 30 forks source link

Updated and reviewed code #2

Closed caydenakins closed 5 years ago

caydenakins commented 5 years ago

Old -> new versions of code available by checking commit history in my repo.

caydenakins commented 5 years ago
{
    "slug": "progressive-web-apps-in-react-with-create-react-app",
    "dependencies": {
        "react": "16.8.6",
        "react-router-dom": "5.0.1",
        "react-scripts": "3.0.1",
        "workbox": "5.0.0-alpha.0"
    },
    "reviews": [
        {
            "performedOn": "2019-07-15",
            "performedBy": 370397,
            "scopeOfReview": "full",
            "notes": [
                {
                    "type": "minor issue",
                    "title": "Workbox Syntax Update",
                    "details": "Changed `workbox.skipWaiting()` to `workbox.core.skipWaiting()` in lessons 4 -> 20 in '/src/sw.js' because of workbox update 4.0.0.\n\nChanged `workbox.clientsClaim()` to `workbox.core.clientsClaim()` in lessons 4 -> 20 in '/src/sw.js' because of workbox update 4.0.0.",
                    "lessons": [
                        "react-use-a-custom-service-worker-in-a-create-react-app-pwa-without-ejecting",
                        "react-pre-cache-static-resources-with-workbox-and-view-a-react-pwa-offline",
                        "react-listen-for-install-and-activate-pwa-events-in-a-service-worker",
                        "react-cache-third-party-resources-from-a-cdn-in-a-react-pwa",
                        "react-cache-json-data-in-a-react-pwa-with-workbox-and-display-it-while-offline",
                        "react-add-an-offline-status-indicator-to-a-pwa-with-react",
                        "react-show-an-error-when-a-post-or-delete-fails-in-an-offline-pwa",
                        "react-add-a-custom-app-icon-to-a-pwa-built-with-create-react-app",
                        "react-change-the-name-and-short-name-of-a-pwa-built-with-create-react-app",
                        "react-add-a-pwa-to-the-home-screen-of-an-ios-or-android-device-and-the-chrome-app-home-screen",
                        "react-add-navigation-elements-in-react-to-a-pwa-in-standalone-mode",
                        "react-access-the-camera-in-a-pwa-built-with-react",
                        "react-add-push-notifications-to-a-pwa-with-react-in-chrome-and-on-android",
                        "react-disable-text-selection-and-touch-callouts-in-a-pwa-on-ios",
                        "react-change-the-status-bar-color-on-ios-and-android-in-a-pwa",
                        "react-customize-the-splash-screen-of-a-pwa-built-with-create-react-app",
                        "react-do-a-pwa-audit-with-lighthouse-using-chrome-dev-tools"
                    ],
                    "dependency": "workbox"
                },
                {
                    "type": "major issue",
                    "title": "Chrome 68 Update Problems",
                    "details": "Changed behavior in Chrome's application tab due to Chrome 68 update adds exceptions to the 'Add to homescreen' button which breaks lessons 12 and 13.",
                    "lessons": [
                        "react-change-the-name-and-short-name-of-a-pwa-built-with-create-react-app",
                        "react-add-a-pwa-to-the-home-screen-of-an-ios-or-android-device-and-the-chrome-app-home-screen"
                    ],
                    "dependency": "workbox"
                }
            ]
        }
    ]
}