eggheadio / egghead-instructor-center

An app for egghead instructors to do instructor things
https://instructor.egghead.io
19 stars 4 forks source link

Fix request lazy running state #122

Closed trevordmiller closed 7 years ago

trevordmiller commented 7 years ago

When the request is re-called, the loading component should display again. For example, currently in the Instructor Center when hitting pages in the paginated lesson list, you can't tell new data is being loaded so it feels broken until the new data replaces the old data; instead a loading spinner should show during the call as it does with the initial call. Off the top of my head I believe the solution is to move the if(running) above the if(data).

trevordmiller commented 7 years ago

Resolved by https://github.com/eggheadio/egghead-instructor-center/pull/151