search

eggheadio / egghead-instructor-center

An app for egghead instructors to do instructor things
https://instructor.egghead.io
19 stars 4 forks source link

Request re-loading and propose form clearing #149

Closed joelhooks closed 7 years ago

joelhooks commented 7 years ago

This first one looks like the technologies are getting called on any input change. Not really a big deal but should probably be throttled. Technologies don't change much.

The server could definitely send back a better error here, but maybe if we just min-length to 5-10 it will stop. It is 5 on the server, but even that is super short.

Right now on error it clears the form and doesn't allow us to re-submit!

trevordmiller commented 7 years ago

Good catch. I've moved it to my board.

trevordmiller commented 7 years ago

This is also a problem on screen switching; the navigation disappears and you have the root loading spinner so the app doesn't feel like a SPA; I need to figure out why Request is making more requests. My guess is I need a shouldComponentUpdate or something. This is at the top of my ready column.

trevordmiller commented 7 years ago

I fixed the navigation re-routing issue by moving the WrappedRequest below it; but this is still annoying; will most likely look into it tomorrow after my current PR.

trevordmiller commented 7 years ago

Will be fixed by https://github.com/eggheadio/egghead-instructor-center/pull/163#pullrequestreview-26436843