search

eggheadio / egghead-instructor-center

An app for egghead instructors to do instructor things
https://instructor.egghead.io
19 stars 4 forks source link

Navbar closes when current link is clicked #224

Closed theianjones closed 7 years ago

theianjones commented 7 years ago

Steps to reproduce:

  1. navigate to instructor center
  2. click on the current link (in the root, it will be Dashboard)

Expected outcome: Nothing to happen. The nav could possibly close and a hamburger show up like in mobile but that's a design choice.

Actual outcome: Nav closes with no way, besides a page refresh, to get it back again.

trevordmiller commented 7 years ago

Thanks for making an issue Ian. I know what the problem is and will take care of it next week.

trevordmiller commented 7 years ago

The nav should only open/close on mobile

trevordmiller commented 7 years ago

Resolved by https://github.com/eggheadio/egghead-instructor-center/pull/225