Closed trevordmiller closed 7 years ago
Should be ready to go now that this is out: https://github.com/eggheadio/egghead-rails/pull/1357#pullrequestreview-33824669
Should we rename the series_url
to courses_url
on the user object? I just added this. The review app is the only front end piece that uses it as of right now.
@ijones16 Some endpoints use "series", some "courses" - would be nice to start using "courses" going forward. It shouldn't be on the user object should it? IMO the root api/v1 should have a "courses_url" (currently "series_url") which gives all courses, and then the instructor should have instructor.courses_url - specific to the instructor
But I'm cool with whatever as long as I can use it. Up to you and @peterkeen
Series
et. al. should be completely internal to egghead-rails
. Everything public facing, including the API, should say courses
. The fact that courses are currently implemented with the Series
object is an implementation detail.
(this is something that I have done a bad job communicating)
I've been able to replace any link building in egghead-ui pieces with hypermedia URLs except for a couple places:
instructor.courses_url
: there isroot.instructor_series_url
) but that is only for the logged in instructor; seems that if an instructor has at least one course published they should get ainstructor.courses_url
like they have ainstructor.lessons_url
. The current link building is inInstructorStats
.root.technologies_url
. The current link building is inProposeLessonForm
.