eggheadio / egghead-ui

egghead UI pieces as a package and app
https://styleguide.egghead.io
28 stars 6 forks source link

Replace /package link building with hypermedia #113

Closed trevordmiller closed 7 years ago

trevordmiller commented 7 years ago

I've been able to replace any link building in egghead-ui pieces with hypermedia URLs except for a couple places:

trevordmiller commented 7 years ago

Should be ready to go now that this is out: https://github.com/eggheadio/egghead-rails/pull/1357#pullrequestreview-33824669

theianjones commented 7 years ago

Should we rename the series_url to courses_url on the user object? I just added this. The review app is the only front end piece that uses it as of right now.

trevordmiller commented 7 years ago

@ijones16 Some endpoints use "series", some "courses" - would be nice to start using "courses" going forward. It shouldn't be on the user object should it? IMO the root api/v1 should have a "courses_url" (currently "series_url") which gives all courses, and then the instructor should have instructor.courses_url - specific to the instructor

trevordmiller commented 7 years ago

But I'm cool with whatever as long as I can use it. Up to you and @peterkeen

peterkeen commented 7 years ago

Series et. al. should be completely internal to egghead-rails. Everything public facing, including the API, should say courses. The fact that courses are currently implemented with the Series object is an implementation detail.

peterkeen commented 7 years ago

(this is something that I have done a bad job communicating)