eggheadio / egghead-ui

egghead UI pieces as a package and app
https://styleguide.egghead.io
28 stars 6 forks source link

Improve LessonOverviews publication list priority #143

Open joelhooks opened 7 years ago

joelhooks commented 7 years ago

The lesson overviews in a tab interface could be presented in a priority that makes more sense in terms of the priority of items within each tab.

The first questions to answer for this screen are:

image

trevordmiller commented 7 years ago

I'm open to any suggestions. Can I get a list of what should be changed? @joelhooks @vojtaholik and I can implement.

vojtaholik commented 7 years ago

I'll provide wires/designs for different roles. Working on it.

trevordmiller commented 7 years ago

@vojtaholik Thanks Vojta. Will wait to hear back from you.

vojtaholik commented 7 years ago

As an editor

As an instructor

As a mentor

Some more thoughts

Quick draft showing what stuff we might do in the future. Please don't take it as "next steps". :) https://egghead.invisionapp.com/d/main/#/console/10461992/233431310/preview

What I think we're missing completely in current version apart of what Joel mentioned is a section like "My Submissions" or "My Lessons" with topics assigned to me, instructor.

Let me know what you think, I'll provide some simple mockups at the beginning of next week. 👍

trevordmiller commented 7 years ago

@vojtaholik @joelhooks

"As an editor"

Sounds good.

"I can imagine a quick "propose topic" card there as well - do you think that would be helpful?"

I could add the ProposeLessonForm easily if you think it would improve the UX; the sub-component in the RequestedLessons component that toggles from "+ PROPOSE A NEW LESSON" to the form.

"As an instructor"

Sounds good. The only thing to note is that the way the LessonOverviewsByGroup component currently works is it is being used in a few places, with different "props" (option variables):

Currently these only show lessons, but I'd like to update it to show all "items" (course and stand-alone lessons).

"As a mentor"

Sounds good.

"Sorting by date, tags, instructor? search function?"

Yes, these would be helpful.

"Are tabs even necessary? If yes, should their order be same for all types of users?"

Any UX that groups things in a useful way is fine. I like the tabs but am open to other ideas, whatever works. One thing to clear up is there are no "different types of users", there is just data which is available to some accounts, so if some data is available we can conditionally display it or display it in a different way. Whatever you think is best is cool with me.

vojtaholik commented 7 years ago

Thanks @trevordmiller

This is how I see basic enhancements based on what we currently have ➡️ https://egghead.invisionapp.com/d/main/#/projects/prototypes/11043434

Tabs order differ based on user type (I'll keep calling it like that:]). Instructors don't see other's work. Just theirs + requested.

I might go more crazy for sure. Oh, and It's actually based on Nick's "Creators' Center Strategy v01" wireframes.

Lemme know what you think, I can make couple more screens with edge cases and empty states.

cc @joelhooks

trevordmiller commented 7 years ago

@vojtaholik Thanks. Left a couple comments on the InVision mocks. I'm cool with whatever Joel wants.

joelhooks commented 7 years ago

This is a good spot to actually summon the man himself to get some input.

cc @nickdpi

trevordmiller commented 7 years ago

@joelhooks @nickdpi would also be good to review this related story: https://github.com/eggheadio/egghead-ui/issues/142

nickdpi commented 7 years ago

Wrote a handful of comments in other GitHub stories and on InVision. Most of this looks good, and it's a lot to digest, so most of my feedback comes in the form of either wanting more specificity (what constitutes the transition from one role to another, the logic around what functions are allowable on each lesson to each role, etc) or having questions (how lessons are sorted when there's a particularly long list, how grouping happens, etc).

It may be that I'm best suited to tackling those detailed questions – maybe I can hop on a brief call with Vojta to chat later this week?

trevordmiller commented 6 years ago

Commenting so I can be unassigned from this