search

eggheadio / egghead-ui

egghead UI pieces as a package and app
https://styleguide.egghead.io
28 stars 6 forks source link

Improve lesson actions #145

Closed trevordmiller closed 7 years ago

trevordmiller commented 7 years ago

Feedback from new instructors: Lesson actions don't appear as call to actions, the icons are confusing since they match the todo list (we need unique icons for each possible lesson state), and Joel suggested the lesson actions could have less-terse text, although with the current design there isn't much room for more than 1-3 words.

trevordmiller commented 7 years ago

image

trevordmiller commented 7 years ago

@vojtaholik Can you please look into this when you have a chance? We need to consider every possible lesson state from here: https://github.com/eggheadio/egghead-ui/blob/master/src/package/utils/lessonStates/index.js#L4-L82

joelhooks commented 7 years ago

@trevordmiller @vojtaholik there's been a lot of thought, which might be a better launching point for design consideration than lines of js.

Can we close this in favor of https://github.com/eggheadio/egghead-ui/issues/142 please?

trevordmiller commented 7 years ago

@joelhooks Yep hadn't seen that yet