search

eggheadio / egghead-ui

egghead UI pieces as a package and app
https://styleguide.egghead.io
28 stars 6 forks source link

Promote egghead logo #90

Closed theianjones closed 5 years ago

theianjones commented 7 years ago

Instructor center currently defines logo: https://github.com/eggheadio/egghead-instructor-center/tree/master/src/components/Logo

We are now using the logo in egghead, in the header: https://github.com/eggheadio/egghead-rails/blob/master/client/app/components/Header/index.js

This component will display our egghead logo. One difference to consider is that the logo in IC is responsive while the one in egghead (currently) is not. This could be passed as a param.

egghead proper logo:

IC egghead logo:

trevordmiller commented 7 years ago

@ijones16 Good idea. Maybe we could have a single Logo component which can be small (eggo only) which could be used in both projects and then default which could be eggo + egghead.io which egghead-rails could use; then the IC can compose <Logo small + IC specific text?

@vojtaholik, @joelhooks, @tayiorbeii, @DrShpongle what are your thoughts on this?

tayiorbeii commented 7 years ago

Good catch & ideas!

joelhooks commented 7 years ago

This will have an "overDark" option, as the eggo logo changes as does the text color.

The actual eggo itself can be an svg Icon + variants?

trevordmiller commented 7 years ago

That sounds like a good idea Joel.

trevordmiller commented 7 years ago

Here is the instructor center logo implementation which could be a good starting point if anyone wants to take a whack at this: https://github.com/eggheadio/egghead-instructor-center/tree/master/src/components/Logo