eggheadio / egghead-ui

egghead UI pieces as a package and app
https://styleguide.egghead.io
28 stars 6 forks source link

Promote Tabs component #95

Closed trevordmiller closed 7 years ago

trevordmiller commented 7 years ago

Vojta has proposed promoting the instructor center Tabs component to egghead-ui in his latest styleguide mocks: https://egghead.invisionapp.com/d/main#/console/10384631/225150686/comments/79600739

Current

https://github.com/eggheadio/egghead-instructor-center/blob/master/src/components/Tabs/index.js

image

image

Mobile: image

Note that the background appears white in these instances because currently the Tabs instances inside the instructor center are always in a Card component, but the background color is transparent.

Proposed changes

None, promote to egghead-ui as is. Mocks show an example with the entire tabs in a Card, and just the tab bodies in a Card which both are already possible with current implementation:

image

tayiorbeii commented 7 years ago

Fixed via https://github.com/eggheadio/egghead-ui/pull/102