Polish Card component

[trevordmiller]

Vojta has proposed some changes to the Card component in his latest styleguide mocks: https://egghead.invisionapp.com/d/main#/console/10384631/225150686/comments/79600739

Current

http://styleguide.egghead.io/?selectedKind=Card&selectedStory=Info&full=0&down=1&left=1&panelRight=0

Note that all this component currently does is render the children passed with a wrapper (background color white, a border radius depending on the level, and box shadow).

Proposed changes

• Add an overDark option for a darker box shadow; default overDark to false

[joelhooks]

@vojtaholik we want to lift every card with that strong of a shadow? So a stack of cards in a grid will have aggressive shadows?

I don't know that I'm digging that.

[vojtaholik]

@joelhooks no, I'll update this, It displays hover state atm. @trevordmiller I'll update this issue and ping you once it's done.

[trevordmiller]

@vojtaholik Thanks 👍

[trevordmiller]

@vojtaholik Is this one ready to go?

[vojtaholik]

@trevordmiller yes, the behavior of cards in live version is fine (looking at https://egghead.io/browse/libraries/redux).

[trevordmiller]

@vojtaholik I guess I'm not sure what should be done for this story; what needs to be updated from the current Card component here: https://styleguide.egghead.io/components/Card (see the variations over light and dark between levels 1 and 2)

[vojtaholik]

Sorry for confusing @trevordmiller

I can't tell whether there's any shadow in styleguide view you've linked to. So just to be sure we're on a same track - I like how cards look in egghead.io/browse section. ;)

I've also updated invision styleguide with these as I promised (sorry it took so long):

But as I said, I don't insist on any changes, it's looking good. We have probably tackled some adjustments with Evgenyi some time ago, so that might be it. :)

Thanks!

[joelhooks]

Should note that we're not using egghead-ui for any of the cards on egghead.io, we built them to spec with the provided design.

[trevordmiller]

Yes there is shadow like that depending on the level used; you can see it by toggling the background color from dark to light in the egghead-ui app; closing this.