search

eggheads / eggdrop-docker

25 stars 24 forks source link

Use latest versions of config.guess and config.sub #10

Closed lag-linaro closed 5 years ago

lag-linaro commented 5 years ago

They have the most up-to-date features and support a greater number of devices.

Signed-off-by: Lee Jones lee.jones@linaro.org

lag-linaro commented 5 years ago

These files have been updated in the upstream repo now.

Once updated/rebased, this can be closed.

vanosg commented 5 years ago

Support added via upstream, and the official-images repo- thanks again for pointing this out!

vanosg commented 5 years ago

Jumped the gun on this- the alt keyservers component is very important, thanks

tianon commented 5 years ago

Regarding alternate keyservers, see https://github.com/docker-library/official-images/issues/4252, especially https://github.com/docker-library/official-images/issues/4252#issuecomment-405749749 (https://github.com/docker-library/php/pull/666).

vanosg commented 5 years ago

Thanks for that pointer, @tianon!

vanosg commented 5 years ago

@lag-linaro just to update you (and anyone else interested) - the develop branch has this support added in the core upstream code, and will eventually merge to the 1.8 branch line as part of 1.8.4. Once 1.8.4 is released, we'll enable arm64 support to that image as well, but for now only the develop branch will have it. For configuration control purposes, we're interested in keeping the codebase the same between docker and source code. If you can make a strong case as why we need to break this now versus in a month or so when .4 releases, I'm happy to entertain your comments! Thanks again for being such a driving force in getting us to integrate this much-needed feature into the codebase.

lag-linaro commented 5 years ago

One month will be fine. No need to break your workflow.

You are more than welcome. Thank you for being so receptive and responsive.