search

eggheads / eggdrop-docker

25 stars 24 forks source link

Add PKG_ADDITIONAL #24

Closed ZarTek-Creole closed 2 years ago

ZarTek-Creole commented 2 years ago

I read them on the github. The question of adding packages comes back. Your concern seems to be to keep the basic image light. You don't want to add any additional default packages. It's just. you have to install what is strictly necessary. On the other hand, nothing prevents during the docker build from having an ARG with a customizable extra package list. So those who want packages can simply define before the build without burdening the original dockerfile.

add an package : docker build --build-arg PKG_ADDITIONAL=tcl-tls in docker-compose 

version: "3.9"
services:
  eggdrop
    build: 
      args:
        - PKG_ADDITIONAL=tcl-tls
vanosg commented 2 years ago

As I understand your implementation of this, this modification would only work for a user running their own local image, not starting with the official image pulled from the Docker repository. This is a good practice for users maintaining their own Dockerfile and building, but using an official image skips the local build step for Docker, so this would not be usable. It's a great hack for others to use if they maintain their own Dockerfile though!

We have a "heavy" image being worked on for publication as an official image right now that has some extra common libraries loaded. I may also look at modifying the entrypoint script to see if we can add something there, but I am a little more wary of that.