eggheads / eggdrop

The Eggdrop IRC Bot
GNU General Public License v2.0
496 stars 88 forks source link

Reverse DNS Lookup Spoofing #13

Open thommey opened 14 years ago

thommey commented 14 years ago
Trac Data
Ticket 13
Reported by BarkerJr
Status assigned
Component Core
Priority major
Milestone 1.8.0
Version 1.8.0 CVS

It turns out that Eggdrop does not check to see if the DNS is spoofed when accepting a telnet session.

Telnet connection: barkerjr.ircd/56705 Denied telnet: barkerjr@barkerjr.ircd, No Access

Now, this would be fine if the host was actually valid for forward resolving. However...

Since it's not verifying the forward DNS, this could be a problem. Reverse DNS is specified by the net-block administrator, so it can easily be invalid, by mistake or intentionally.

So, this could be a problem, as any net-block admin can spoof hostnames and telnet to your bot as a known user's hostname, rendering protect-telnet ineffective.

michaelortmann commented 3 years ago

CWE-350

michaelortmann commented 9 months ago

please. close, because CANT FIX. reasoning: http://jdebp.info/FGA/dns-avoid-double-reverse.html