search

eggheads / eggdrop

The Eggdrop IRC Bot
GNU General Public License v2.0
510 stars 84 forks source link

chan desync regression #1604

Open michaelortmann opened 5 months ago

michaelortmann commented 5 months ago

For eggdrop 1.9.5 #1374 has been merged

Side effect is a chan desync

For example stats.mod now continuously prints like the following every minute:

Channel '#test' desynched: 2 eggmembers vs 1 statsmembers. Resynching...

See full example log here:

https://pastebin.com/xS6Fhbj8

michaelortmann commented 5 months ago

In this regard it is interesting that #1374 introduced the WHO_SYNC flag

because it just happened, when developing #1593, i noticed the WHO_SYNC flag in clear_channel() is used in a way, thatg i cant maintain / understand it fully, where it is altered when reset is set but then discarded in init_channel() along with the user record, that is also called when reset is set. It was decided to let it be with #1593, because no real world problem could be shown. Now here we have a real world problem that could be bound to the WHO_SYNC design.