search

eggheads / eggdrop

The Eggdrop IRC Bot
GNU General Public License v2.0
508 stars 84 forks source link

Log account changes as join, not mode console level. #1696

Open DasBrain opened 1 month ago

DasBrain commented 1 month ago

(Only channel ops can change modes, users can change their own account)

Found by: DasBrain Patch by: DasBrain Fixes:

One-line summary: Account changes are logged using +j (join, parts, quits, aways and netsplits) not +k (kick, bans and mode changes) console level.

Additional description (if needed):

Test cases demonstrating functionality (if applicable):

thommey commented 1 month ago

what's the rationale for changing it? we deliberately thought JOIN is suitable

DasBrain commented 1 month ago

Currently account changes are logged as mode changes, not join.

A channel member doing a /msg NickServ identify should is not a mode change, which may for example be audited. (A log with mode changes/kicks can be used as audit log for operator actions - an ordinary channel member logging some stuff in there doesn't fit it in my opinion.)

So I agree:

we deliberately thought JOIN is suitable