Open Cizzle opened 7 years ago
Should the NO_OLD_BOTNET macros be removed and thus no longer support linking to pre 1.3.x bots? Or are you suggesting leaving the macros and just changing to #define NO_OLD_BOTNET
by default?
Some notes from review:
#ifndef
around it (I believe it should be though).#ifndef
around it on the C_Bot[] array.)#ifndef
in the C_bot[] array look like they're taken care of properly.Hope that helps. Let me know if you would like me to take a stab at implementing it.
I suggest to first add the define in a future version (1.8.4? 1.9?) and then in a following version remove it altogether.
Will probably be easier to do this right with the new console logging modes added.
Might be time to
#define NO_OLD_BOTNET
in eggdrop.h by default as this is still something from before eggdrop v1.3. Need to precede this by double-checking no old botmessage commands are used anymore (like "error" still is).