eggheads / eggdrop

The Eggdrop IRC Bot
GNU General Public License v2.0
497 stars 84 forks source link

Use NO_OLD_BOTNET by default #430

Open Cizzle opened 7 years ago

Cizzle commented 7 years ago

Might be time to #define NO_OLD_BOTNET in eggdrop.h by default as this is still something from before eggdrop v1.3. Need to precede this by double-checking no old botmessage commands are used anymore (like "error" still is).

orkim commented 7 years ago

Should the NO_OLD_BOTNET macros be removed and thus no longer support linking to pre 1.3.x bots? Or are you suggesting leaving the macros and just changing to #define NO_OLD_BOTNET by default?

orkim commented 7 years ago

Some notes from review:

Hope that helps. Let me know if you would like me to take a stab at implementing it.

Cizzle commented 7 years ago

I suggest to first add the define in a future version (1.8.4? 1.9?) and then in a following version remove it altogether.

Will probably be easier to do this right with the new console logging modes added.