search

eggheads / eggdrop

The Eggdrop IRC Bot
GNU General Public License v2.0
510 stars 84 forks source link

Threads | tpool support #823

Open TimerWolf opened 5 years ago

TimerWolf commented 5 years ago

After many times to try suggest that this should be fixed its never have been done so...

So i try make a issue for it, i have not test this for years do but i am quite sure the lack of support still is there.

Threads work fine and have done so for quite long in eggdrop but the tpool never worked out well as eggdrop won´t know what threads that should be started and closed....

The tpool documentation can be found here and can be very useful depending on what you need to do.

michaelortmann commented 3 years ago

Is this related to #1115? What does "tpool never worked out well" mean? How can i reproduce the problem?

TimerWolf commented 3 years ago

As i understand it this was not a part of the problem...

It's years i did play with tpool, but if i not remember wrong i think that "thommey" told me that it never was going to work as it not was integrated..

Anyways the problem as i remeber it was that if you create a tpool where the settings is the fallowing

set tpool [tpool::create -minworkers 1 -maxworkers 5]

Then it will alwasys be "one" thread open that waiting for some work to come, just like eggdrop main process itself, and it also allowed to open another "four" threads as the maximum workers is set to "five" but its always "one" open in the background as it will get faster to insert the job instead of load up the thread and close it every time as i understand the function.

And how i remember it eggdrop never understood how many workers that was allowed to be open and closed but this is maybe 10 years ago i did play with it so a lot have happen from that time.

thommey commented 1 year ago

It is possible that #1115 fixed this. Someone just needs to test it with the tpool command