search

eggjs / egg-prometheus

Prometheus plugin for Egg.js
https://egg-prometheus.vercel.app
MIT License
39 stars 9 forks source link

feat: Add new request_total metrics #6

Closed xujihui1985 closed 5 years ago

xujihui1985 commented 5 years ago

counter metrics should be named after xxx_total instead of xxx_rate deprecate xxx_rate metrics and add new xxx_total metric

codecov[bot] commented 5 years ago

Codecov Report

Merging #6 into master will increase coverage by 0.13%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   96.14%   96.27%   +0.13%     
==========================================
  Files          14       14              
  Lines         285      295      +10     
==========================================
+ Hits          274      284      +10     
  Misses         11       11
Impacted Files Coverage Δ
lib/metrics/http_server.js 100% <100%> (ø) :arrow_up:
lib/metrics/rpc_client.js 100% <100%> (ø) :arrow_up:
lib/metrics/rpc_server.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49c1046...849a13c. Read the comment docs.

gxcsoccer commented 5 years ago

1.2.0