Closed ghost closed 6 years ago
/cc:@dead-horse。This will fix the rest problem when your domain doesn't match domain_white_list. So as for protocalWhiteList
(make them in lowerCase()
in union).
Thanks for your time of reviewing!
Merging #44 into master will increase coverage by
<.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 95.86% 95.87% +<.01%
==========================================
Files 30 30
Lines 484 485 +1
==========================================
+ Hits 464 465 +1
Misses 20 20
Impacted Files | Coverage Δ | |
---|---|---|
lib/middlewares/hsts.js | 100% <ø> (ø) |
:arrow_up: |
lib/helper/surl.js | 92.3% <100%> (-2.94%) |
:arrow_down: |
app/middleware/securities.js | 95.23% <100%> (+1.29%) |
:arrow_up: |
app/extend/context.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 81f757a...68adfdb. Read the comment docs.
@dead-horse : All is fixed.
LGTM
Thanks anyway!
Change Logs:
1) securities.js:Add convert
whiteList
andprotocalWhiteList
to thelowerCase()
in union. 2) context.js: Remove undefined condition, because this has been done insecurities.js
. 3) surl.js: Make the header in the samelowerCase()
. 4) hsts.js: Remove the comment's 1st line's empty space at the end (auto fixed by eslint). 5) utils.test.js: Change comments by fixing typos. 6) test\fixtures\apps\isSafeDomain\app\router.js: Add more unit tests to test with. 7) test\fixtures\apps\isSafeDomain\config\config.js: Add more domainWhiteList items for testing.